There's been a couple of issues raised this week which suggest we may need to have a generic discussion on module duplication and the code review process. As a result, I'm starting this thread, with the intent of 'genericizing' the discussion a bit ... stepping back from the details from the existing examples (and hopefully filtering some of the emotion out of the conversation as a result.) As one of the 'new guys' in the house, and with an outstanding application in the queue, I have some strong opinions regarding this subject - and as a result, my arguments are going to strongly favor one side of the debate ... please take this as an invitation for dialogue, as opposed to an attack on the opposing viewpoint.
Over the last couple days, I've read over a number of d.o. threads on this topic, and have attempted to incorporate them into the (admittedly biased) summary below. The first post discusses the 'purpose' for the Module Duplication check, while the rest of my posts deal with individual issues that may arise (or already exist) with the application of module duplication rules in the code review process.
I've broken things up into multiple posts in an attempt to maintain context within any comments which might follow ... please try to stick with this model while responding (breaking up responses in to different comments for each thread), and ensure you are actually replying on the conversation thread that you are commenting on.