This module has generated some discussion recently, and I feel really bad for the project owner. He went through a process of correcting things that a few reviewers pointed out to him. Then Joachim came along and said that he thought the module should be implemented as a Context plugin. The project owner basically said that he didn't want to do that and marked it 'needs review'. I found it after it had been sitting for another four weeks. I thought Joachim had abandoned the review, so I took a look at it and said I thought it was OK and should be approved.
Joachim disagreed, and that is what started the discussion. I asked zzolo to get involved because of the disagreement, and his conclusion was that Joachim's objection should not block approval, but he marked it 'needs work'. This confused the project owner, who basically said 'what am I supposed to do now? It also confused me, and when I asked zzolo about it, he said he had marked it 'needs work' by mistake, and that it would be OK to change it back.
Meanwhile Dave Reid has come along and said, wait a minute, is there some duplication with the Theme Key module? The project owner hasn't responded, and I think he has just walked away in frustration, and understandably so. When I looked at the project, I didn't even think about module duplication, because I assumed that would have been looked at early in the process. I looked into it, and as it turns out, there may be some overlap in functionality between the two, but it seems really wrong to me for somebody to come along at the very end of the process and say this doesn't pass muster because of module duplication. There may be an issue of overall utility, since the auto switching is only a small feature of Theme Key, but its all that Theme Autoswitch does. Still I think that out of fairness to this project owner, this application should be marked RTBC. I'd like to get some consensus before going ahead and changing it. I actually like the small modules that do one thing and don't load you down with code that you don't need.