We need to clearly define the goals of the Full Project Applications process (and possibly name it better). There is currently some outlined on the how to review. Also, see zzolo's post on overall way of building process.
Critical:
- Licensing - Code/images copied from other sources must be licensed GPLv2 and later.
- Security - We should try to catch all security issues in this stage AND educate the developer about them so they won't make more of the same mistake.
Overall value for the process:
- Mentoring - view this as an opportunity to teach rather than one to criticize.
- Welcoming - these are the rockstars of Drupal's future. Bow down before them and welcome them.
Should not block an application but are worthy of review:
- Module duplication - if possible reduce module duplication, but if a maintainer believes their module is different in some way then accept their word.
- Best practices and coding standards - mostly important if they impede the ability to review other elements